misc(v2): change blog front matter to snake_case #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangshun
commented
Nov 14, 2019
| @@ -1,3 +1,10 @@ | |||
| /** | |||
There was a problem hiding this comment.
Changes in this file are just nits.
| @@ -11,7 +18,7 @@ export function truncate(fileString: string, truncateMarker: RegExp | string) { | |||
| } | |||
|
|
|||
| // YYYY-MM-DD-{name}.mdx? | |||
| // prefer named capture, but old node version do not support | |||
| // prefer named capture, but old Node version does not support. | |||
| const FILENAME_PATTERN = /^(\d{4}-\d{1,2}-\d{1,2})-?(.*?).mdx?$/; | |||
|
|
|||
| function toUrl({date, link}: DateLink) { | |||
There was a problem hiding this comment.
@endiliey why is there a hardcoded date 2019-01-01 here? On L53 as well o.o
There was a problem hiding this comment.
Not me who put that. Iirc its hardcoded that way by some prevs contributor who added cjk support.
He wanted to make it clear that its yyyy-mm-dd and then take the length lol.
There was a problem hiding this comment.
Maybe just substring(0,9) lol
|
Deploy preview for docusaurus-2 ready! Built with commit 79760c1 |
|
Deploy preview for docusaurus-preview ready! Built with commit 79760c1 |
endiliey
added
the
pr: breaking change
endiliey
reviewed
Nov 14, 2019
yangshun
force-pushed
the
yangshun/blog
branch
from
6b54868 to
85b5e1f
Compare
|
@endiliey done. Thanks for the tip |
endiliey
approved these changes
Nov 19, 2019
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Standardize our front matter. Front matter should be snake_case 🐍. I'm preserving the camelCase for legacy reasons, so users using the camelCase will still work.
Also, I'm removing two following fields:
authorFBID- This is really unnecessary and we don't need it. People should just provide the FB Graph API image URL if they wanted a FB profile pictureauthorTwitter- This was never ported to D2, but is still in the template and examplesI'm not updating the docs and template yet because it should be done only after alpha.35 is published or else there will be a mismatch between the doc and latest version.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Blog loads.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)